docs: fix incorrect parameter count in token-swap README (#494)#591
Open
plutohan wants to merge 1 commit into
Open
docs: fix incorrect parameter count in token-swap README (#494)#591plutohan wants to merge 1 commit into
plutohan wants to merge 1 commit into
Conversation
dev-jodee
approved these changes
Jun 24, 2026
Collaborator
|
@plutohan can you rebase, CI should be fixed now, and also we need signed commits for merging in our repos |
dev-jodee
requested changes
Jun 24, 2026
dev-jodee
left a comment
dev-jodee
left a comment
Collaborator
There was a problem hiding this comment.
signed commit + rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #494.
The
tokens/token-swapREADME saysswap_exact_tokens_for_tokens"takes five parameters", but the function takes four —ctx,swap_a,input_amount,min_output_amount(seeanchor/programs/token-swap/src/lib.rsandsrc/instructions/swap_exact_tokens_for_tokens.rs). The numbered list directly below the sentence already enumerates only those four, so this corrects "five" → "four".Markdown-only change; no code or tests touched.